From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 14B8529DFF for ; Mon, 29 Sep 2014 05:43:23 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id E8F738F8035 for ; Mon, 29 Sep 2014 03:43:19 -0700 (PDT) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id fTljjRUdGbJPTCNu (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 29 Sep 2014 03:43:18 -0700 (PDT) Date: Mon, 29 Sep 2014 03:43:18 -0700 From: Christoph Hellwig Subject: Re: [PATCH] xfs: compat_xfs_bstat does not have forkoff Message-ID: <20140929104318.GA10847@infradead.org> References: <1411954886-12200-1-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1411954886-12200-1-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Mon, Sep 29, 2014 at 11:41:26AM +1000, Dave Chinner wrote: > From: Dave Chinner > > struct compat_xfs_bstat is missing the di_forkoff field and so does > not fully translate the structure correctly. Fix it. > > Signed-off-by: Dave Chinner > --- > fs/xfs/xfs_ioctl32.c | 2 ++ > fs/xfs/xfs_ioctl32.h | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) Looks good, Reviewed-by: Christoph Hellwig Any chance to get an xfstests test that verifies the forkoff value? Even if it would only reproduce this bug when running 32-bit userspace on a 64-bit kernel it would be useful I think. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs