From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 840A07FCB for ; Mon, 29 Sep 2014 07:18:57 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 72DB9304032 for ; Mon, 29 Sep 2014 05:18:54 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id jAAZfz1p5gyZCLBW (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 29 Sep 2014 05:18:53 -0700 (PDT) Date: Mon, 29 Sep 2014 08:18:21 -0400 From: Brian Foster Subject: Re: [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable() Message-ID: <20140929121821.GA65297@bfoster.bfoster> References: <1411647632-28240-1-git-send-email-david@fromorbit.com> <1411647632-28240-2-git-send-email-david@fromorbit.com> <20140925161756.GA25798@infradead.org> <20140925210330.GG4945@dastard> <20140926094436.GA10692@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140926094436.GA10692@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Fri, Sep 26, 2014 at 02:44:36AM -0700, Christoph Hellwig wrote: > On Fri, Sep 26, 2014 at 07:03:30AM +1000, Dave Chinner wrote: > > I can mention it, but it's so trivial I didn't think it was worth > > it. > > It does change behavior, so it should document why that was changed. > > > The changelog says "Hence allow the caller to pass in the freeze > > level it is allowed to write" which is exactly what this code is > > doing. > > The changelog says the you can pass the argument now. It doesn't > say that it did change a caller to pass a different argument, and more > importanly why. > Note that iirc the patch I posted had a bug so this one is preferred, but feel free to steal the commit log/problem description from the old one: http://oss.sgi.com/archives/xfs/2014-08/msg00073.html Brian > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs