From: Jan Kara <jack@suse.cz>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Jan Kara <jack@suse.cz>, xfs@oss.sgi.com
Subject: Re: xfstests test xfs/030 failure
Date: Wed, 1 Oct 2014 16:45:34 +0200 [thread overview]
Message-ID: <20141001144534.GF17405@quack.suse.cz> (raw)
In-Reply-To: <542C02D1.3090809@sandeen.net>
On Wed 01-10-14 08:34:09, Eric Sandeen wrote:
> On 10/1/14 4:45 AM, Jan Kara wrote:
> > Hello,
> >
> > I'm getting failure for text xfs/030 like:
> > xfs/030 9s ... - output mismatch (see /var/lib/xfstests/results//xfs/030.out.bad)
> > --- tests/xfs/030.out 2014-09-30 19:36:53.000000000 +0200
> > +++ /var/lib/xfstests/results//xfs/030.out.bad 2014-09-30 22:11:38.000000000 +0200
> > @@ -39,8 +39,8 @@
> > - traversal finished ...
> > - moving disconnected inodes to lost+found ...
> > Phase 7 - verify and correct link counts...
> > -Note - stripe unit (0) and width (0) fields have been reset.
> > -Please set with mount -o sunit=<value>,swidth=<value>
> > +Note - stripe unit (0) and width (0) were copied from a backup superblock.
> > +Please reset with mount -o sunit=<value>,swidth=<value> if necessary
> > ...
> > (Run 'diff -u tests/xfs/030.out /var/lib/xfstests/results//xfs/030.out.bad' to see the entire diff)
> >
> > Now obviously this is because I run xfsprogs 3.2.1 but xfstests have
> > message from older version of xfsprogs. What is a standard solution for
> > this? If I just replace the messages, then people with older xfsprogs will
> > see failures. So some kind of a filter?
> >
> > Honza
> >
>
>
> Hi Jan, this should fix it, are you up to date?
> (Sorry to all involved for changing this output w/o fixing the tests myself
> at the same time...)
Ah, sorry. Mea culpa. My xfstests repository was checked out on some
local branch so I didn't have the recent commit... Thanks for pointing me
in the right direction.
Honza
>
> commit f007c2b465e331317e91b5125e8da04826e57c82
> Author: Dave Chinner <dchinner@redhat.com>
> Date: Mon Sep 8 20:48:59 2014 +1000
>
> filter: update xfs_repair filter for new sunit/swidth warning
>
> New xfs_repair programs have a different sunit/swidth warning that
> is triggering failures such as:
>
> -Note - stripe unit (0) and width (0) fields have been reset.
> -Please set with mount -o sunit=<value>,swidth=<value>
> +Note - stripe unit (0) and width (0) were copied from a backup superblock.
> +Please reset with mount -o sunit=<value>,swidth=<value> if necessary
>
> Update the filter to catch both cases and output the old message so
> tests pass again.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
>
>
> -Eric
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-10-01 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 9:45 xfstests test xfs/030 failure Jan Kara
2014-10-01 13:34 ` Eric Sandeen
2014-10-01 14:45 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001144534.GF17405@quack.suse.cz \
--to=jack@suse.cz \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox