From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 1/2] xfs: don't send null bp to xfs_trans_brelse()
Date: Wed, 1 Oct 2014 08:55:29 -0700 [thread overview]
Message-ID: <20141001155529.GA787@infradead.org> (raw)
In-Reply-To: <542C1C2B.5020803@sandeen.net>
On Wed, Oct 01, 2014 at 10:22:19AM -0500, Eric Sandeen wrote:
> In this case, if bp is NULL, error is set, and we send a
> NULL bp to xfs_trans_brelse, which will try to dereference it.
>
> Test whether we actually have a buffer before we try to
> free it.
>
> Coverity spotted this.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-10-01 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 15:18 [PATCH 0/2 RESEND] xfs: small bugfixes Eric Sandeen
2014-10-01 15:22 ` [PATCH 1/2] xfs: don't send null bp to xfs_trans_brelse() Eric Sandeen
2014-10-01 15:55 ` Christoph Hellwig [this message]
2014-10-01 15:24 ` [PATCH 2/2] xfs: fix crc field handling in xfs_sb_to/from_disk Eric Sandeen
2014-10-01 15:56 ` Christoph Hellwig
2014-10-01 22:56 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001155529.GA787@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox