From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: compat_xfs_bstat does not have forkoff
Date: Thu, 2 Oct 2014 08:54:20 +1000 [thread overview]
Message-ID: <20141001225420.GB10298@dastard> (raw)
In-Reply-To: <20140929104318.GA10847@infradead.org>
On Mon, Sep 29, 2014 at 03:43:18AM -0700, Christoph Hellwig wrote:
> On Mon, Sep 29, 2014 at 11:41:26AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > struct compat_xfs_bstat is missing the di_forkoff field and so does
> > not fully translate the structure correctly. Fix it.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > ---
> > fs/xfs/xfs_ioctl32.c | 2 ++
> > fs/xfs/xfs_ioctl32.h | 3 ++-
> > 2 files changed, 4 insertions(+), 1 deletion(-)
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Any chance to get an xfstests test that verifies the forkoff value?
> Even if it would only reproduce this bug when running 32-bit userspace
> on a 64-bit kernel it would be useful I think.
There are already xfs_fsr tests that are dependent on forkoff being
set to correctly defrag a file successfully. The fact that nobody
has noticed that these fail tends to imply nobody runs xfstests with
a 32 bit userspace on 64 bit kernels....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-10-01 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 1:41 [PATCH] xfs: compat_xfs_bstat does not have forkoff Dave Chinner
2014-09-29 10:43 ` Christoph Hellwig
2014-10-01 22:54 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001225420.GB10298@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox