From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id F3B5E7F3F for ; Fri, 10 Oct 2014 07:08:01 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id D399430407B for ; Fri, 10 Oct 2014 05:07:58 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id FFXddYGzglNebutV (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 10 Oct 2014 05:07:57 -0700 (PDT) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9AC7tHr019252 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 10 Oct 2014 08:07:56 -0400 Date: Fri, 10 Oct 2014 08:07:54 -0400 From: Brian Foster Subject: Re: [PATCH] xfs: lock for removing item from cil->xc_cil in xlog_cil_push Message-ID: <20141010120754.GB18297@bfoster.bfoster> References: <929991500.42327290.1412926226461.JavaMail.zimbra@redhat.com> <2090211370.42327532.1412926306812.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2090211370.42327532.1412926306812.JavaMail.zimbra@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Xu Wang Cc: xfs@oss.sgi.com T24gRnJpLCBPY3QgMTAsIDIwMTQgYXQgMDM6MzE6NDZBTSAtMDQwMCwgWHUgV2FuZyB3cm90ZToK PiBGcm9tIDU5YzZiYWJhYjdjNGNlODcwODAzNjAxODE0M2QyYWNjMTQ3N2NjN2YgTW9uIFNlcCAx NyAwMDowMDowMCAyMDAxCj4gRnJvbTogR2VvcmdlIFdhbmcgPHh1d0ByZWRoYXQuY29tPgo+IERh dGU6IEZyaSwgMTAgT2N0IDIwMTQgMTU6MDI6MTQgKzA4MDAKPiBTdWJqZWN0OiBbUEFUQ0hdIFtQ QVRDSF0geGZzOiBsb2NrIGZvciByZW1vdmluZyBpdGVtIGZyb20gY2lsLT54Y19jaWwgaW4KPiAg eGxvZ19jaWxfcHVzaAo+IAo+IFRoZXJlIGlzIGEgcmFjZSBjb25kaXRpb24gd2hlbiB4bG9nX2Np bF9mb3JjZV9sc24gYW5kIHhsb2dfY2lsX3B1c2ggZm9yCj4gY2lsLT54Y19jaWwgaXRlbXMuIFdo ZW4gZnVuY3Rpb24geGxvZ19jaWxfcHVzaF9ub3cgY2FsbGVkIGluCj4geGxvZ19jaWxfZm9yY2Vf bHNuLCBhbmQgdGhlIHhsb2dfY2lsX3B1c2ggcnVuIGluIHdvcmtxdWV1ZSBqdXN0IHJlYWNoZXMg dGhlIHBvaW50IGZvcgo+IHNldHRpbmcgY2lsLT54Y19jdXJyZW50X3NlcXVlbmNlLCB0aGUgeGxv Z19jaWxfZm9yY2VfbHNuIGdvdCB0aGUgbG9jawo+IGFuZCBjaGVjayB0aGUgInNlcXVlbmNlID09 IGNpbC0+eGNfY3VycmVudF9zZXF1ZW5jZSAmJgo+ICFsaXN0X2VtcHR5KCZjaWwtPnhjX2NpbCki IGZvciByZXN0YXJ0LiBUaGUgc3RhdGVtZW50ICJzZXF1ZW5jZSA9PQo+IGNpbC0+eGNfY3VycmVu dF9zZXF1ZW5jZSIgaXMgdHJ1ZSwgYnV0IHRoZSBjaWwtPnhjX2NpbCBpcyBlbXB0eQo+IGFjY29y ZGluZyB0byB0aGUgeGxvZ19jaWxfcHVzaCByZW1vdmVkIHRoZSBpdGVtcyBpbiBjaWwtPnhjX2Np bCB3aXRob3V0Cj4gbG9jayBwcm90ZWN0aW9ubC4gU28gdGhlIGZ1bmN0aW9uIHhsb2dfY2lsX2Zv cmNlX2xzbiB3aWxsIHJldHVybgo+IE5VTExDT01NSVRMU04sIHdoaWNoIG1lYW5zIHRoZSBjaWwg bG9nIGZvciBjdXJyZW50IHNlcXVlbmNlIHdpbGwgbm90IGJlCj4gc3VibWl0dGVkIHRvIGRpc2su IEFuZCBpZiB0aGVyZSBpcyBubyBtb3JlIG9wZXJhdGlvbnMoZm9yIGV4YW1wbGUsIHdoZW4KPiB1 bm1vdW50IGZzLCB0aGlzIHNpdHVhdGlvbiBoYXBwZW5lZCBpbgo+IHhmc191bm1vdW50ZnMtPnhm c19sb2dfc2Jjb3VudC0+eGZzX3RyYW5zX2NvbW1pdCksIHRoZSB4ZnMgd2lsbCBoYW5nIHVwLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IEdlb3JnZSBXYW5nIDx4dXdAcmVkaGF0LmNvbT4KPiAtLS0KCklz bid0IHRoaXMgZml4ZWQgYnkgdGhlIGZvbGxvd2luZyBjb21taXQ/Cgo4YWYzZGNkMyB4ZnM6IHhs b2dfY2lsX2ZvcmNlX2xzbiBkb2Vzbid0IGFsd2F5cyB3YWl0IGNvcnJlY3RseQoKV2l0aCB0aGF0 IHBhdGNoLCB4bG9nX2NpbF9wdXNoKCkgYWRkcyB0aGUgY3R4IHRvIHRoZSBjb21taXR0aW5nIGxp c3QKYmVmb3JlIGRyYWluaW5nIHRoZSBjdHggYW5kIHVwZGF0aW5nIHRoZSBjdXJyZW50IHNlcXVl bmNlIG51bWJlci4KeGxvZ19jaWxfZm9yY2VfbHNuKCkgd2Fsa3MgdGhlIGNvbW1pdHRpbmcgbGlz dCBhbmQgY2hlY2tzIHRoZSBzZXF1ZW5jZQpudW1iZXIgYW5kIGN0eCBsaXN0LCBhbGwgdW5kZXIg dGhlIHB1c2ggbG9jay4KClRoYXQgbWVhbnMgdGhhdCB4bG9nX2NpbF9mb3JjZV9sc24oKSBzaG91 bGQgc2VlIHRoZSBjdHggZWl0aGVyIG9uIHRoZQpjb21taXR0aW5nIGxpc3QgYW5kIHdhaXQgZm9y IGl0IChjb21taXRfbHNuICE9IE5VTEwpLCBvciBub3Qgb24gdGhlCmNvbW1pdHRpbmcgbGlzdCBh dCBhbGwuIElmIGl0J3Mgbm90IG9uIHRoZSBjb21taXR0aW5nIGxpc3QgeWV0LAp4bG9nX2NpbF9w dXNoKCkgd29uJ3QgaGF2ZSBlaXRoZXIgZHJhaW5lZCB0aGUgY3R4IG9yIHVwZGF0ZWQgdGhlCnNl cXVlbmNlIG51bWJlciwgYXMgaXQgYWRkcyB0byB0aGUgY29tbWl0dGluZyBsaXN0IGZpcnN0IGFu ZCB0aGF0CnJlcXVpcmVzIHRoZSBwdXNoIGxvY2sgKHdoaWNoIHhsb2dfY2lsX2ZvcmNlX2xzbigp IGhvbGRzIGFuZCBkb2Vzbid0CnJlbGVhc2UgdW50aWwgYWZ0ZXIgdGhlIHJlc3RhcnQgY2hlY2sp LgoKQW0gSSBtaXNzaW5nIHNvbWV0aGluZz8gRG8geW91IHJlcHJvZHVjZSBhIHByb2JsZW0gd2l0 aCB0aGUgbGF0ZXN0IHRyZWUKdGhhdCBpbmNsdWRlcyB0aGUgYWJvdmUgcGF0Y2g/CgpCcmlhbgoK PiAgZnMveGZzL3hmc19sb2dfY2lsLmMgfCAzICsrLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2ZzL3hmcy94ZnNfbG9n X2NpbC5jIGIvZnMveGZzL3hmc19sb2dfY2lsLmMKPiBpbmRleCBmNmI3OWU1Li45N2JhNTI3IDEw MDY0NAo+IC0tLSBhL2ZzL3hmcy94ZnNfbG9nX2NpbC5jCj4gKysrIGIvZnMveGZzL3hmc19sb2df Y2lsLmMKPiBAQCAtNDc4LDYgKzQ3OCw4IEBAIHhsb2dfY2lsX3B1c2goCj4gICAgICAqLwo+ICAg ICBsdiA9IE5VTEw7Cj4gICAgIG51bV9pb3ZlY3MgPSAwOwo+ICsKPiArICAgc3Bpbl9sb2NrKCZj aWwtPnhjX3B1c2hfbG9jayk7Cj4gICAgIHdoaWxlICghbGlzdF9lbXB0eSgmY2lsLT54Y19jaWwp KSB7Cj4gICAgICAgICBzdHJ1Y3QgeGZzX2xvZ19pdGVtICppdGVtOwo+IAo+IEBAIC01MzAsNyAr NTMyLDYgQEAgeGxvZ19jaWxfcHVzaCgKPiAgICAgICogYWdhaW5zdCB0aGUgY3VycmVudCBzZXF1 ZW5jZSBpbiBsb2cgZm9yY2VzIHdpdGhvdXQgcmlza2luZwo+ICAgICAgKiBkZWZlcmVuY2luZyBh IGZyZWVkIGNvbnRleHQgcG9pbnRlci4KPiAgICAgICovCj4gLSAgIHNwaW5fbG9jaygmY2lsLT54 Y19wdXNoX2xvY2spOwo+ICAgICBjaWwtPnhjX2N1cnJlbnRfc2VxdWVuY2UgPSBuZXdfY3R4LT5z ZXF1ZW5jZTsKPiAgICAgbGlzdF9hZGQoJmN0eC0+Y29tbWl0dGluZywgJmNpbC0+eGNfY29tbWl0 dGluZyk7Cj4gICAgIHNwaW5fdW5sb2NrKCZjaWwtPnhjX3B1c2hfbG9jayk7Cj4gLS0gCj4gMS45 LjMKPiAKPiAKPiAtLSAKPiBHZW9yZ2UgV2FuZyDnjovml60KPiAKPiBLZXJuZWwgUXVhbnRpdHkg RW5naW5lZXIKPiBSZWQgSGF0IFNvZnR3YXJlIChCZWlqaW5nKSBDby4sTHRkCj4gSVJDOnh1dwo+ IFRlbDorODYtMDEwLTYyNjA4MDQxCj4gUGhvbmU6MTU5MDEyMzE1NzkKPiA5L0YsIFRvd2VyIEMs IFJheWNvbQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4geGZzIG1haWxpbmcgbGlzdAo+IHhmc0Bvc3Muc2dpLmNvbQo+IGh0dHA6Ly9vc3Muc2dp LmNvbS9tYWlsbWFuL2xpc3RpbmZvL3hmcwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KeGZzIG1haWxpbmcgbGlzdAp4ZnNAb3NzLnNnaS5jb20KaHR0cDov L29zcy5zZ2kuY29tL21haWxtYW4vbGlzdGluZm8veGZzCg==