From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 096FD7FC2 for ; Fri, 10 Oct 2014 10:20:17 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id EC0F730404E for ; Fri, 10 Oct 2014 08:20:13 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id Jb6POPiwbebCCBpq (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 10 Oct 2014 08:20:13 -0700 (PDT) Date: Fri, 10 Oct 2014 11:19:06 -0400 From: Dave Jones Subject: Re: [PATCH] block: free q->flush_rq in blk_init_allocated_queue error paths Message-ID: <20141010151906.GB8874@redhat.com> References: <1412951028-4085-1-git-send-email-jack@suse.cz> <1412951028-4085-3-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1412951028-4085-3-git-send-email-jack@suse.cz> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jan Kara Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, tytso@mit.edu, Jeff Mahoney , Jens Axboe , Mark Fasheh , reiserfs-devel@vger.kernel.org, xfs@oss.sgi.com, cluster-devel@redhat.com, Joel Becker , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Linus Torvalds , Steven Whitehouse , ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk On Fri, Oct 10, 2014 at 04:23:07PM +0200, Jan Kara wrote: > From: Dave Jones > > Commit 7982e90c3a57 ("block: fix q->flush_rq NULL pointer crash on > dm-mpath flush") moved an allocation to blk_init_allocated_queue(), but > neglected to free that allocation on the error paths that follow. > > Signed-off-by: Dave Jones > Acked-by: Mike Snitzer > Signed-off-by: Jens Axboe > Signed-off-by: Linus Torvalds Um, This got applied months ago. Dave _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs