* [PATCH] xfsprogs: fix harmless sparse endian nit
@ 2014-10-23 23:44 Eric Sandeen
2014-10-27 11:26 ` Brian Foster
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2014-10-23 23:44 UTC (permalink / raw)
To: xfs-oss
h_crc is __le32 but cpu_to_be32() is... __be32. So sparse
complains, even though it's harmless.
Although sparse is smart about bare 0s, and we could
drop the swap, other places explicitly swap to keep
things clear (I guess?) so "swap" the 0 with the proper
routine.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index 9ee89d3..dd8baa6 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -187,7 +187,7 @@ libxfs_log_header(
head->h_len = cpu_to_be32(sunit - BBSIZE);
else
head->h_len = cpu_to_be32(20);
- head->h_crc = cpu_to_be32(0);
+ head->h_crc = cpu_to_le32(0);
head->h_prev_block = cpu_to_be32(-1);
head->h_num_logops = cpu_to_be32(1);
head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfsprogs: fix harmless sparse endian nit
2014-10-23 23:44 [PATCH] xfsprogs: fix harmless sparse endian nit Eric Sandeen
@ 2014-10-27 11:26 ` Brian Foster
0 siblings, 0 replies; 2+ messages in thread
From: Brian Foster @ 2014-10-27 11:26 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Thu, Oct 23, 2014 at 06:44:49PM -0500, Eric Sandeen wrote:
> h_crc is __le32 but cpu_to_be32() is... __be32. So sparse
> complains, even though it's harmless.
>
> Although sparse is smart about bare 0s, and we could
> drop the swap, other places explicitly swap to keep
> things clear (I guess?) so "swap" the 0 with the proper
> routine.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Looks good. I agree that the swap helps with clarity.
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
> index 9ee89d3..dd8baa6 100644
> --- a/libxfs/rdwr.c
> +++ b/libxfs/rdwr.c
> @@ -187,7 +187,7 @@ libxfs_log_header(
> head->h_len = cpu_to_be32(sunit - BBSIZE);
> else
> head->h_len = cpu_to_be32(20);
> - head->h_crc = cpu_to_be32(0);
> + head->h_crc = cpu_to_le32(0);
> head->h_prev_block = cpu_to_be32(-1);
> head->h_num_logops = cpu_to_be32(1);
> head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-27 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-23 23:44 [PATCH] xfsprogs: fix harmless sparse endian nit Eric Sandeen
2014-10-27 11:26 ` Brian Foster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox