* [PATCH] xfsprogs: two more completely harmless sparse nits
@ 2014-10-23 23:59 Eric Sandeen
2014-10-27 11:26 ` Brian Foster
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2014-10-23 23:59 UTC (permalink / raw)
To: xfs-oss
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/repair/prefetch.c b/repair/prefetch.c
index 65f8456..7ea0d36 100644
--- a/repair/prefetch.c
+++ b/repair/prefetch.c
@@ -171,7 +171,7 @@ pf_read_bmbt_reclist(
struct xfs_buf_map map_array[MAP_ARRAY_SZ];
struct xfs_buf_map *map = map_array;
int max_extents = MAP_ARRAY_SZ;
- int nmaps = 0;;
+ int nmaps = 0;
unsigned int len = 0;
int ret = 0;
diff --git a/rtcp/xfs_rtcp.c b/rtcp/xfs_rtcp.c
index b81b1e1..5f26a62 100644
--- a/rtcp/xfs_rtcp.c
+++ b/rtcp/xfs_rtcp.c
@@ -25,7 +25,7 @@ int pflag;
char *progname;
void
-usage()
+usage(void)
{
fprintf(stderr, _("%s [-e extsize] [-p] [-V] source target\n"), progname);
exit(2);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfsprogs: two more completely harmless sparse nits
2014-10-23 23:59 [PATCH] xfsprogs: two more completely harmless sparse nits Eric Sandeen
@ 2014-10-27 11:26 ` Brian Foster
0 siblings, 0 replies; 2+ messages in thread
From: Brian Foster @ 2014-10-27 11:26 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Thu, Oct 23, 2014 at 06:59:11PM -0500, Eric Sandeen wrote:
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/repair/prefetch.c b/repair/prefetch.c
> index 65f8456..7ea0d36 100644
> --- a/repair/prefetch.c
> +++ b/repair/prefetch.c
> @@ -171,7 +171,7 @@ pf_read_bmbt_reclist(
> struct xfs_buf_map map_array[MAP_ARRAY_SZ];
> struct xfs_buf_map *map = map_array;
> int max_extents = MAP_ARRAY_SZ;
> - int nmaps = 0;;
> + int nmaps = 0;
> unsigned int len = 0;
> int ret = 0;
>
> diff --git a/rtcp/xfs_rtcp.c b/rtcp/xfs_rtcp.c
> index b81b1e1..5f26a62 100644
> --- a/rtcp/xfs_rtcp.c
> +++ b/rtcp/xfs_rtcp.c
> @@ -25,7 +25,7 @@ int pflag;
> char *progname;
>
> void
> -usage()
> +usage(void)
> {
> fprintf(stderr, _("%s [-e extsize] [-p] [-V] source target\n"), progname);
> exit(2);
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-27 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-23 23:59 [PATCH] xfsprogs: two more completely harmless sparse nits Eric Sandeen
2014-10-27 11:26 ` Brian Foster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox