From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/6 v2] xfs: fix the bulkstat mess
Date: Fri, 7 Nov 2014 00:02:16 +1100 [thread overview]
Message-ID: <20141106130216.GE23575@dastard> (raw)
In-Reply-To: <20141106124907.GA31429@bfoster.bfoster>
On Thu, Nov 06, 2014 at 07:49:08AM -0500, Brian Foster wrote:
> There's a simple test for that condition, as noted in my previous mail
> as well in case you missed it. Again, that probably calls out that we
> could be doing better unit testing of bulkstat in xfstests. At the very
> least we probably need some bulkstat inode count validation against a
> known data set.
That's exactly what I've been running to find this latest problem.
But a 500TB filesystem with 10 million inodes in it is a bit beyond
xfstests. ANd that only showed up the problem in 4 AGs out of 500,
so with smaller filesystems there's a good chance that this would
have also been missed....
> xfsdump testing is obviously important, but if bulkstat
> is broken then we clearly can't expect xfsdump to work (and debugging
> the former via the latter appears to be quite painful).
We have a bulkstat command in xfstests. And it can be used to
comapre the output against a stat of the file. But it can't detect
missing inodes and I don't think we can start at arbitrary inodes,
either. So it needs work to be able to be used in unit tests.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-11-06 13:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 0:05 [PATCH 0/6 v2] xfs: fix the bulkstat mess Dave Chinner
2014-11-05 0:05 ` [PATCH 1/6] xfs: bulkstat btree walk doesn't terminate Dave Chinner
2014-11-05 0:05 ` [PATCH 2/6] xfs: bulkstat chunk formatting cursor is broken Dave Chinner
2014-11-05 0:05 ` [PATCH 3/6] xfs: bulkstat chunk-formatter has issues Dave Chinner
2014-11-05 14:59 ` Brian Foster
2014-11-05 0:05 ` [PATCH 4/6] xfs: bulkstat main loop logic is a mess Dave Chinner
2014-11-05 0:05 ` [PATCH 5/6] xfs: bulkstat error handling is broken Dave Chinner
2014-11-05 0:05 ` [PATCH 6/6] xfs: track bulkstat progress by agino Dave Chinner
2014-11-05 15:14 ` Brian Foster
2014-11-05 6:07 ` [PATCH 0/6 v2] xfs: fix the bulkstat mess Dave Chinner
2014-11-05 6:32 ` Dave Chinner
2014-11-05 13:17 ` Brian Foster
2014-11-05 21:21 ` Dave Chinner
2014-11-06 6:53 ` Dave Chinner
2014-11-06 12:49 ` Brian Foster
2014-11-06 13:02 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106130216.GE23575@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox