From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>, xfs@oss.sgi.com
Subject: Re: beginners project: RENAME_WHITEOUT
Date: Sun, 9 Nov 2014 10:42:32 +1100 [thread overview]
Message-ID: <20141108234232.GJ28565@dastard> (raw)
In-Reply-To: <20141107190959.GB21021@infradead.org>
On Fri, Nov 07, 2014 at 11:09:59AM -0800, Christoph Hellwig wrote:
> The overlayfs merge introduces a new rename flag to create to whiteouts.
> Should be a fairly easy to implement.
>
> Miklos, do you have any good documentation and/or test cases for this?
So overlayfs uses some weird char dev hack to implement whiteout
inodes in directories? Why do we need a whiteout inode on disk?
what information is actually stored in the whiteout inode that
overlayfs actually needs? Only readdir and lookup care about
whiteouts, and AFAICT nothing of the inode is ever used except
checking the chrdev/whiteoutdev hack via ovl_is_whiteout(dentry).
Indeed, whatever happened to just storing the whiteout in the dirent
via DT_WHT and using that information on lookup in the lower
filesystem to mark the dentry returned appropriately without needing
to lookup a real inode?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-11-08 23:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 19:09 beginners project: RENAME_WHITEOUT Christoph Hellwig
2014-11-07 22:59 ` Eric Sandeen
2014-11-08 6:40 ` Christoph Hellwig
2014-11-09 0:08 ` cem
2014-11-08 23:42 ` Dave Chinner [this message]
2014-11-10 9:25 ` Miklos Szeredi
2014-11-10 13:52 ` Dave Chinner
2014-11-10 16:55 ` Miklos Szeredi
2015-01-09 13:30 ` Carlos Maiolino
2015-01-22 1:05 ` Dave Chinner
2014-11-10 9:14 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141108234232.GJ28565@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=miklos@szeredi.hu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox