From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com, Brian Foster <bfoster@redhat.com>
Subject: Re: [PATCH 2/2] Add support to RENAME_EXCHANGE flag V3
Date: Thu, 13 Nov 2014 09:00:44 +1100 [thread overview]
Message-ID: <20141112220044.GB23575@dastard> (raw)
In-Reply-To: <20141112173245.GA32185@hades.localdomain>
On Wed, Nov 12, 2014 at 03:32:48PM -0200, Carlos Maiolino wrote:
> > > + if (new_parent) {
> > > + xfs_trans_ichgtime(tp, target_dp, XFS_ICHGTIME_MOD |
> > > XFS_ICHGTIME_CHG);
> >
> > Long line.
> >
> I think there is no reason to break this line. We should avoid 80+ columns per
> line, but it's not a must, break this line will hurt readability of the code in
> exchange of just a few chars more than 80. I don't think it's worth.
You're not going to win that argument, Carlos: new code wraps at 80
columns. This:
if (new_parent) {
xfs_trans_ichgtime(tp, target_dp,
XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
.....
}
Is no less readable on a wide terminal than a single line, and it
doesn't end up a mess for people who use 80 column terminals for the
code editing. Please fix it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-11-12 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 17:01 [PATCH 0/2] Add support to RENAME_EXCHANGE flat to XFS V3 Carlos Maiolino
2014-11-11 17:01 ` [PATCH 1/2] Make xfs_vn_rename compliant with renameat2() syscall Carlos Maiolino
2014-11-11 19:28 ` Brian Foster
2014-11-11 17:01 ` [PATCH 2/2] Add support to RENAME_EXCHANGE flag V3 Carlos Maiolino
2014-11-11 19:29 ` Brian Foster
2014-11-12 17:32 ` Carlos Maiolino
2014-11-12 22:00 ` Dave Chinner [this message]
2014-11-13 13:04 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112220044.GB23575@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox