From: Dave Chinner <david@fromorbit.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: xfs@oss.sgi.com
Subject: Re: XFS locking issues in 3.18-rc3+
Date: Sat, 15 Nov 2014 10:02:42 +1100 [thread overview]
Message-ID: <20141114230242.GD29950@dastard> (raw)
In-Reply-To: <CALCETrU+D70HzUFh4qfnKqit7vA0TkZCus1+GNBCC4R=_KXDVg@mail.gmail.com>
On Fri, Nov 14, 2014 at 02:05:43PM -0800, Andy Lutomirski wrote:
> On Fri, Nov 14, 2014 at 1:50 PM, Dave Chinner <david@fromorbit.com> wrote:
> > On Fri, Nov 14, 2014 at 01:02:59PM -0800, Andy Lutomirski wrote:
> >> On Thu, Nov 13, 2014 at 9:25 PM, Dave Chinner <david@fromorbit.com> wrote:
> >> > On Thu, Nov 13, 2014 at 04:57:11PM -0800, Andy Lutomirski wrote:
> >> >> I'm running a kernel somewhere between 3.18-rc3 and 3.18-rc4. I got
> >> >> the warnings below. Is this a known issue?
> >> >
> >> > Yup, false positive. shmem is instantiating an inode under the
> >> > mmap_sem and in doing so taking inode locks under the mmap_sem,
> >> > which triggers other filesystems to issue false warnings about
> >> > mmap_sem <-> inode lock order.
> >>
> >> I still have an enormous flood of warnings even if
> >> CONFIG_PROVE_LOCKING=n. This one is repeated at high frequency:
> >>
> >> [ 70.969118] ------------[ cut here ]------------
> >> [ 70.969121] WARNING: CPU: 8 PID: 653 at mm/truncate.c:758
> >> pagecache_isize_extended+0x105/0x110()
> >
> > Fixed in 3.18-rc4.
>
> Yeah, I just confirmed that, too. Thanks. (The lockdep splat is
> still there, but that's much less annoying.)
Fixing the lockdep split is, unfortunately, a lot more work. I've
basically got to redesign the way readdir does readahead to hold
locks in different ways and so we don't need to hold various locks
of the filldir callout where the might_fault() triggers the
warnings.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-11-14 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 0:57 XFS locking issues in 3.18-rc3+ Andy Lutomirski
2014-11-14 5:25 ` Dave Chinner
2014-11-14 21:02 ` Andy Lutomirski
2014-11-14 21:50 ` Dave Chinner
2014-11-14 22:05 ` Andy Lutomirski
2014-11-14 23:02 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114230242.GD29950@dastard \
--to=david@fromorbit.com \
--cc=luto@amacapital.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox