From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id F0A2D7F4E for ; Fri, 14 Nov 2014 17:02:50 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 8E856AC005 for ; Fri, 14 Nov 2014 15:02:47 -0800 (PST) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id 5wREDOhJ1r5JhWBl for ; Fri, 14 Nov 2014 15:02:45 -0800 (PST) Date: Sat, 15 Nov 2014 10:02:42 +1100 From: Dave Chinner Subject: Re: XFS locking issues in 3.18-rc3+ Message-ID: <20141114230242.GD29950@dastard> References: <20141114052523.GB29950@dastard> <20141114215007.GC29950@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Andy Lutomirski Cc: xfs@oss.sgi.com On Fri, Nov 14, 2014 at 02:05:43PM -0800, Andy Lutomirski wrote: > On Fri, Nov 14, 2014 at 1:50 PM, Dave Chinner wrote: > > On Fri, Nov 14, 2014 at 01:02:59PM -0800, Andy Lutomirski wrote: > >> On Thu, Nov 13, 2014 at 9:25 PM, Dave Chinner wrote: > >> > On Thu, Nov 13, 2014 at 04:57:11PM -0800, Andy Lutomirski wrote: > >> >> I'm running a kernel somewhere between 3.18-rc3 and 3.18-rc4. I got > >> >> the warnings below. Is this a known issue? > >> > > >> > Yup, false positive. shmem is instantiating an inode under the > >> > mmap_sem and in doing so taking inode locks under the mmap_sem, > >> > which triggers other filesystems to issue false warnings about > >> > mmap_sem <-> inode lock order. > >> > >> I still have an enormous flood of warnings even if > >> CONFIG_PROVE_LOCKING=n. This one is repeated at high frequency: > >> > >> [ 70.969118] ------------[ cut here ]------------ > >> [ 70.969121] WARNING: CPU: 8 PID: 653 at mm/truncate.c:758 > >> pagecache_isize_extended+0x105/0x110() > > > > Fixed in 3.18-rc4. > > Yeah, I just confirmed that, too. Thanks. (The lockdep splat is > still there, but that's much less annoying.) Fixing the lockdep split is, unfortunately, a lot more work. I've basically got to redesign the way readdir does readahead to hold locks in different ways and so we don't need to hold various locks of the filldir callout where the might_fault() triggers the warnings. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs