Re: [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff

Jan Kara
2014-11-18T16:07:35Z

On Thu 13-11-14 09:36:00, Christoph Hellwig wrote:
> > static const struct quotactl_ops ext4_qctl_sysfile_operations = {
> > - .quota_on_meta = ext4_quota_on_sysfile,
> > - .quota_off = ext4_quota_off_sysfile,
> > + .sysquota_on = dquot_sysquota_on,
> > + .sysquota_off = dquot_sysquota_off,
> > .quota_sync = dquot_quota_sync,
> > .get_info = dquot_get_dqinfo,
> > .set_info = dquot_set_dqinfo,
>
> This vector now only has generic dquot_ methods. Maybe move the
> vector to fs/quota/dquot.c and allow multiple filesystems to share it?
Right. ocfs2 actually has the same vector now. I'll unify it.

Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR