From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 893807F6D for ; Mon, 24 Nov 2014 09:21:07 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 7870930407F for ; Mon, 24 Nov 2014 07:21:04 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by cuda.sgi.com with ESMTP id eWaLYP5vR0nxIktL (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 24 Nov 2014 07:21:03 -0800 (PST) Date: Mon, 24 Nov 2014 07:21:01 -0800 From: Christoph Hellwig Subject: Re: [PATCH 1/4] fs: split update_time() into update_time() and write_time() Message-ID: <20141124152101.GA12575@infradead.org> References: <1416599964-21892-1-git-send-email-tytso@mit.edu> <1416599964-21892-2-git-send-email-tytso@mit.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1416599964-21892-2-git-send-email-tytso@mit.edu> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Theodore Ts'o Cc: linux-fsdevel@vger.kernel.org, Ext4 Developers List , linux-btrfs@vger.kernel.org, xfs@oss.sgi.com On Fri, Nov 21, 2014 at 02:59:21PM -0500, Theodore Ts'o wrote: > We needed to preserve update_time() because btrfs wants to have a > special btrfs_root_readonly() check; otherwise we could drop the > update_time() inode operation entirely. Can't btrfs just set the immutable flag on every inode that is read when the root has the BTRFS_ROOT_SUBVOL_RDONLY flag? That would cut down the places that need this check to the ioctl path so that we prevent users from clearling the immutable flag. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs