From: Dave Chinner <david@fromorbit.com>
To: Peter Watkins <treestem@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: overflow in xfs_iomap_eof_align_last_fsb
Date: Wed, 26 Nov 2014 10:18:28 +1100 [thread overview]
Message-ID: <20141125231828.GA9561@dastard> (raw)
In-Reply-To: <1416855973-6359-1-git-send-email-treestem@gmail.com>
On Mon, Nov 24, 2014 at 02:06:13PM -0500, Peter Watkins wrote:
> Someone else may have run into this already, if not please take
> a look.
>
> Peter
>
> If extsize is set and new_last_fsb is larger than 32 bits, the
> roundup to extsize will overflow the align variable. Instead,
> combine alignments by rounding extsize hint up to stripe size.
Change of allocator behaviour that will cause significant problems
for applications that depend on deterministic behaviour from the
extent size hint.
i.e. The extsize hint is supposed to override all other alignments
that are made - extent size hints are effectively a "unit of
allocation". Hence we round up to stripe unit/width, then apply the
extent size hint alignment so that extent sizes are always aligned
to the extent size hint....
....
> @@ -52,7 +52,7 @@ xfs_iomap_eof_align_last_fsb(
> xfs_extlen_t extsize,
> xfs_fileoff_t *last_fsb)
> {
> - xfs_fileoff_t new_last_fsb = 0;
> + xfs_fileoff_t new_last_fsb;
That can be declared in the context that uses it now.
> xfs_extlen_t align = 0;
> int eof, error;
>
> @@ -70,23 +70,24 @@ xfs_iomap_eof_align_last_fsb(
> else if (mp->m_dalign)
> align = mp->m_dalign;
>
> - if (align && XFS_ISIZE(ip) >= XFS_FSB_TO_B(mp, align))
> - new_last_fsb = roundup_64(*last_fsb, align);
> + if (align && XFS_ISIZE(ip) < XFS_FSB_TO_B(mp, align))
> + align = 0;
> }
>
> /*
> - * Always round up the allocation request to an extent boundary
> - * (when file on a real-time subvolume or has di_extsize hint).
> + * Round up the allocation request to an extent boundary. If
> + * already aligned to a stripe, round extsize up to a stripe
> + * boundary.
> */
Drop the comment change...
> if (extsize) {
> - if (new_last_fsb)
> - align = roundup_64(new_last_fsb, extsize);
> + if (align)
> + align = roundup_64(extsize, align);
align = roundup(align, extsize);
> else
> align = extsize;
> - new_last_fsb = roundup_64(*last_fsb, align);
> }
>
> - if (new_last_fsb) {
> + if (align) {
> + new_last_fsb = roundup_64(*last_fsb, align);
xfs_fileoff_t new_last_fsb = roundup_64(*last_fsb, align);
> error = xfs_bmap_eof(ip, new_last_fsb, XFS_DATA_FORK, &eof);
> if (error)
> return error;
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-11-25 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 19:06 [PATCH] xfs: overflow in xfs_iomap_eof_align_last_fsb Peter Watkins
2014-11-25 13:49 ` Brian Foster
2014-11-25 23:18 ` Dave Chinner [this message]
2014-12-01 22:45 ` [PATCH v2] " Peter Watkins
2014-12-02 16:24 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125231828.GA9561@dastard \
--to=david@fromorbit.com \
--cc=treestem@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox