From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id D1BE47F4E for ; Thu, 27 Nov 2014 09:25:10 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id B12288F8049 for ; Thu, 27 Nov 2014 07:25:07 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id 2wg4NWhe4I50FKgT (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Thu, 27 Nov 2014 07:25:06 -0800 (PST) Date: Thu, 27 Nov 2014 07:25:04 -0800 From: Christoph Hellwig Subject: Re: [PATCH-v4 1/7] vfs: split update_time() into update_time() and write_time() Message-ID: <20141127152504.GA15839@infradead.org> References: <1416997437-26092-1-git-send-email-tytso@mit.edu> <1416997437-26092-2-git-send-email-tytso@mit.edu> <20141126192328.GA20436@infradead.org> <20141127123429.GD30152@quack.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20141127123429.GD30152@quack.suse.cz> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jan Kara Cc: Linux Filesystem Development List , Ext4 Developers List , Theodore Ts'o , Linux btrfs Developers List , XFS Developers On Thu, Nov 27, 2014 at 01:34:29PM +0100, Jan Kara wrote: > But Ted changed XFS to copy timestamps to on-disk structure from the > in-memory inode fields after VFS updated the timestamps. So the stamps > should be coherent AFAICT, shouldn't they? Not coherent enough. We need the XFS ilock to synchronize reading from and writing to the time stamps. update_time() only has i_mutex, which we can't take for the transaction commit path. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs