From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 2A81A7F4E for ; Thu, 27 Nov 2014 10:49:59 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id A2009AC003 for ; Thu, 27 Nov 2014 08:49:55 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id Gow4tpqfKbahqfqc (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Thu, 27 Nov 2014 08:49:54 -0800 (PST) Date: Thu, 27 Nov 2014 08:49:52 -0800 From: Christoph Hellwig Subject: Re: [PATCH-v4 1/7] vfs: split update_time() into update_time() and write_time() Message-ID: <20141127164952.GA1622@infradead.org> References: <1416997437-26092-1-git-send-email-tytso@mit.edu> <1416997437-26092-2-git-send-email-tytso@mit.edu> <20141126192328.GA20436@infradead.org> <20141127144116.GA14091@thunk.org> <20141127153315.GC14091@thunk.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20141127153315.GC14091@thunk.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Theodore Ts'o Cc: Christoph Hellwig , Linux Filesystem Development List , Ext4 Developers List , Linux btrfs Developers List , XFS Developers I don't think this scheme works well. As mentioned earlier XFS doesn't even use vfs dirty tracking at the moment, so introducing this in a hidden way sounds like a bad idea. Probably the same for btrfs. I'd rather keep update_time as-is for now, don't add ->write_time and let btrfs and XFS figure out how to implement the semantics on their own. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs