From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id B25327F51 for ; Sun, 30 Nov 2014 17:09:28 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 419B6AC002 for ; Sun, 30 Nov 2014 15:09:25 -0800 (PST) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id S6N5pN6nEeMiBvzo for ; Sun, 30 Nov 2014 15:09:19 -0800 (PST) Date: Mon, 1 Dec 2014 10:09:04 +1100 From: Dave Chinner Subject: Re: [PATCH 1/1] XFS: Deletion of unnecessary checks before two function calls Message-ID: <20141130230904.GF16151@dastard> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5479F823.60900@users.sourceforge.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5479F823.60900@users.sourceforge.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: SF Markus Elfring Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML , xfs@oss.sgi.com On Sat, Nov 29, 2014 at 05:45:23PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 29 Nov 2014 17:40:22 +0100 > > The functions xfs_blkdev_put() and xfs_qm_dqrele() test whether their argument > is NULL and then return immediately. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs