From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: move type conversion functions to xfs_dir.h
Date: Wed, 3 Dec 2014 08:52:08 +1100 [thread overview]
Message-ID: <20141202215208.GC18131@dastard> (raw)
In-Reply-To: <20141202113626.GA30327@infradead.org>
On Tue, Dec 02, 2014 at 03:36:26AM -0800, Christoph Hellwig wrote:
> On Tue, Dec 02, 2014 at 10:18:03AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > These are currently considered private to libxfs, but they are
> > widely used by the userspace code to decode, walk and check
> > directory structures. Hence they really form part of the external
> > API and as such need to bemoved to xfs_dir2.h.
>
> Lokos good, but why do we need the additional includes in various files?
Because the conversion functions have a dependency on the struct
xfs_da_geometry definition in xfs_da_btree.h. xfs_dir2_priv.h had
that dependency, but xfs_dir2.h didn't. Now the conversion functions
have been moved, that dependency moves as well...
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Did you mean Reviewed-by? :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-12-02 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 23:18 [PATCH 0/2] libxfs: make some dir2 definitions public Dave Chinner
2014-12-01 23:18 ` [PATCH 1/2] xfs: move ftype conversion functions to libxfs Dave Chinner
2014-12-02 9:23 ` Christoph Hellwig
2014-12-01 23:18 ` [PATCH 2/2] xfs: move type conversion functions to xfs_dir.h Dave Chinner
2014-12-02 11:36 ` Christoph Hellwig
2014-12-02 21:52 ` Dave Chinner [this message]
2014-12-03 10:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141202215208.GC18131@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox