From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix set-but-unused warnings
Date: Wed, 3 Dec 2014 09:05:03 +1100 [thread overview]
Message-ID: <20141202220503.GE18131@dastard> (raw)
In-Reply-To: <20141202092310.GA25767@infradead.org>
On Tue, Dec 02, 2014 at 01:23:10AM -0800, Christoph Hellwig wrote:
> On Tue, Dec 02, 2014 at 02:09:01PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > The kernel compile doesn't turn on these checks by default, so it's
> > only when I do a kernel-user sync that I find that there are lots of
> > compiler warnings waiting to be fixed. Fix up these set-but-unused
> > warnings.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> Looks good. Maybe we should enable those warnings for fs/xfs?
I now have a local patch (-Werror -Wunused-but-set-variable) that
catches these during my for-next integration testing workflow, so
I should catch them (and other errors) during review....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-12-02 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 3:09 [PATCH] xfs: fix set-but-unused warnings Dave Chinner
2014-12-02 3:13 ` Eric Sandeen
2014-12-02 9:23 ` Christoph Hellwig
2014-12-02 22:05 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141202220503.GE18131@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox