From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs: lobotomise xfs_trans_read_buf_map()
Date: Wed, 3 Dec 2014 02:53:41 -0800 [thread overview]
Message-ID: <20141203105341.GB3727@infradead.org> (raw)
In-Reply-To: <20141202230706.GH18131@dastard>
> /*
> * Get and lock the buffer for the caller if it is not already
> * locked within the given transaction. If it has not yet been
> @@ -255,46 +248,11 @@ xfs_trans_read_buf_map(
> struct xfs_buf **bpp,
> const struct xfs_buf_ops *ops)
> {
> - xfs_buf_t *bp;
> - xfs_buf_log_item_t *bip;
> + struct xfs_buf *bp = NULL;
> + struct xfs_buf_log_item *bip;
> int error;
>
> *bpp = NULL;
> + /*
> + * If we've had a read error, then the contents of the buffer are
> + * invalid and shoul dnot be used. To ensure that a followup read tries
should not
Otherwise looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-12-03 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 22:34 [PATCH] xfs: lobotomise xfs_trans_read_buf_map() Dave Chinner
2014-12-02 16:59 ` Christoph Hellwig
2014-12-02 22:45 ` Dave Chinner
2014-12-02 23:07 ` [PATCH v2] " Dave Chinner
2014-12-03 10:53 ` Christoph Hellwig [this message]
2014-12-03 10:51 ` [PATCH] " Christoph Hellwig
2014-12-03 14:09 ` Mark Tinguely
2014-12-03 19:54 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203105341.GB3727@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox