From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 66C8A7F4E for ; Mon, 15 Dec 2014 12:24:56 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 3AD56304039 for ; Mon, 15 Dec 2014 10:24:54 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by cuda.sgi.com with ESMTP id J4vjG75ApM2n38E4 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 15 Dec 2014 10:24:53 -0800 (PST) Date: Mon, 15 Dec 2014 10:24:53 -0800 From: Christoph Hellwig Subject: Re: [PATCH] xfs: remove extra newlines from xfs messages Message-ID: <20141215182453.GA15673@infradead.org> References: <548B6E07.8080302@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <548B6E07.8080302@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs-oss On Fri, Dec 12, 2014 at 04:36:55PM -0600, Eric Sandeen wrote: > xfs_warn() and friends add a newline by default, but some > messages add another one. > > Particularly for the failing write message below, this can > waste a lot of console real estate! > > Signed-off-by: Eric Sandeen Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs