From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Keep sb_bad_features2 consistent with sb_features2
Date: Thu, 18 Dec 2014 08:22:55 +1100 [thread overview]
Message-ID: <20141217212255.GZ24183@dastard> (raw)
In-Reply-To: <1418848046-11265-1-git-send-email-jack@suse.cz>
On Wed, Dec 17, 2014 at 09:27:26PM +0100, Jan Kara wrote:
> Currently when we modify sb_features2, we store the same value also in
> sb_bad_features2. However in most places we forget to mark field
> sb_bad_features2 for logging and thus it can happen that a change to it
> is lost. This results in an inconsistent sb_features2 and
> sb_bad_features2 fields e.g. after xfstests test xfs/187.
>
> Fix the problem by changing XFS_SB_FEATURES2 to actually mean both
> sb_features2 and sb_bad_features2 fields since this is always what we
> want to log. This isn't ideal because the fact that XFS_SB_FEATURES2
> means two fields could cause some problem in future however the code is
> hopefully less error prone that it is now.
Actually, I have patches that fix this differently that I'm planning
to push for the 3.20 cycle. They get rid of the "update random SB
fields" problem altogether simply by logging and updating the entire
SB every time.
http://oss.sgi.com/archives/xfs/2014-09/msg00448.html
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/xfs/libxfs/xfs_format.h | 10 +++++-----
> fs/xfs/xfs_mount.c | 5 ++---
> 2 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
> index fbd6da263571..476273287aaf 100644
> --- a/fs/xfs/libxfs/xfs_format.h
> +++ b/fs/xfs/libxfs/xfs_format.h
> @@ -304,8 +304,8 @@ typedef enum {
> #define XFS_SB_ICOUNT XFS_SB_MVAL(ICOUNT)
> #define XFS_SB_IFREE XFS_SB_MVAL(IFREE)
> #define XFS_SB_FDBLOCKS XFS_SB_MVAL(FDBLOCKS)
> -#define XFS_SB_FEATURES2 XFS_SB_MVAL(FEATURES2)
> -#define XFS_SB_BAD_FEATURES2 XFS_SB_MVAL(BAD_FEATURES2)
> +#define XFS_SB_FEATURES2 (XFS_SB_MVAL(FEATURES2) | \
> + XFS_SB_MVAL(BAD_FEATURES2))
That doesn't guarantee that both fields are updated together, just
that the'll get logged and written together. The code still has to
ensure both fields are updated beforehand. I have a patch to address
this as well, and will post them soon.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-12-17 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 20:27 [PATCH] xfs: Keep sb_bad_features2 consistent with sb_features2 Jan Kara
2014-12-17 21:22 ` Dave Chinner [this message]
2014-12-18 9:59 ` Jan Kara
2014-12-23 22:17 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217212255.GZ24183@dastard \
--to=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox