From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Keep sb_bad_features2 consistent with sb_features2
Date: Wed, 24 Dec 2014 09:17:46 +1100 [thread overview]
Message-ID: <20141223221746.GI4521@dastard> (raw)
In-Reply-To: <20141218095919.GA13705@quack.suse.cz>
On Thu, Dec 18, 2014 at 10:59:19AM +0100, Jan Kara wrote:
> On Thu 18-12-14 08:22:55, Dave Chinner wrote:
> > On Wed, Dec 17, 2014 at 09:27:26PM +0100, Jan Kara wrote:
> > > Currently when we modify sb_features2, we store the same value also in
> > > sb_bad_features2. However in most places we forget to mark field
> > > sb_bad_features2 for logging and thus it can happen that a change to it
> > > is lost. This results in an inconsistent sb_features2 and
> > > sb_bad_features2 fields e.g. after xfstests test xfs/187.
> > >
> > > Fix the problem by changing XFS_SB_FEATURES2 to actually mean both
> > > sb_features2 and sb_bad_features2 fields since this is always what we
> > > want to log. This isn't ideal because the fact that XFS_SB_FEATURES2
> > > means two fields could cause some problem in future however the code is
> > > hopefully less error prone that it is now.
> >
> > Actually, I have patches that fix this differently that I'm planning
> > to push for the 3.20 cycle. They get rid of the "update random SB
> > fields" problem altogether simply by logging and updating the entire
> > SB every time.
> >
> > http://oss.sgi.com/archives/xfs/2014-09/msg00448.html
> OK, thanks for info.
FWIW, I'll pull the fixes you have posted and rebase the rework I
have on top of them. That way we have fixes that can be backported
easily without pulling the entire rework in the commit history.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-12-23 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 20:27 [PATCH] xfs: Keep sb_bad_features2 consistent with sb_features2 Jan Kara
2014-12-17 21:22 ` Dave Chinner
2014-12-18 9:59 ` Jan Kara
2014-12-23 22:17 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141223221746.GI4521@dastard \
--to=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox