From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 7E9497F54 for ; Mon, 19 Jan 2015 03:00:40 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 5D9A98F8039 for ; Mon, 19 Jan 2015 01:00:38 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id bgaCUeIlqlUYgZVZ (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 19 Jan 2015 01:00:36 -0800 (PST) Date: Mon, 19 Jan 2015 01:00:35 -0800 From: Christoph Hellwig Subject: Re: [PATCH 01/17] quota: Split ->set_xstate callback into two Message-ID: <20150119090035.GA27474@infradead.org> References: <1421412471-4747-1-git-send-email-jack@suse.cz> <1421412471-4747-2-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1421412471-4747-2-git-send-email-jack@suse.cz> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, xfs@oss.sgi.com On Fri, Jan 16, 2015 at 01:47:35PM +0100, Jan Kara wrote: > Split ->set_xstate callback into two callbacks - one for turning quotas > on (->quota_enable) and one for turning quotas off (->quota_disable). That > way we don't have to pass quotactl command into the callback which seems > cleaner. > > Signed-off-by: Jan Kara Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs