From: Jan Kara <jack@suse.cz>
To: Brian Foster <bfoster@redhat.com>
Cc: Jan Kara <jack@suse.cz>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: Remove useless test
Date: Tue, 20 Jan 2015 17:44:00 +0100 [thread overview]
Message-ID: <20150120164400.GB3648@quack.suse.cz> (raw)
In-Reply-To: <20150115132754.GA23696@bfoster.bfoster>
On Thu 15-01-15 08:27:54, Brian Foster wrote:
> On Thu, Jan 15, 2015 at 11:18:03AM +0100, Jan Kara wrote:
> > Q_XQUOTARM is never passed to xfs_fs_set_xstate() so remove the test.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
Thanks for reviews! I've pulled the XFS cleanups from this series into my
tree.
Honza
> > fs/xfs/xfs_quotaops.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
> > index 7542bbeca6a1..8fcd20dbf89a 100644
> > --- a/fs/xfs/xfs_quotaops.c
> > +++ b/fs/xfs/xfs_quotaops.c
> > @@ -75,7 +75,7 @@ xfs_fs_set_xstate(
> >
> > if (sb->s_flags & MS_RDONLY)
> > return -EROFS;
> > - if (op != Q_XQUOTARM && !XFS_IS_QUOTA_RUNNING(mp))
> > + if (!XFS_IS_QUOTA_RUNNING(mp))
> > return -ENOSYS;
> >
> > if (uflags & FS_QUOTA_UDQ_ACCT)
> > --
> > 2.1.2
> >
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-01-20 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 10:18 [PATCH 0/3] xfs: Quota related cleanups Jan Kara
2015-01-15 10:18 ` [PATCH 1/3] xfs: Remove useless test Jan Kara
2015-01-15 13:27 ` Brian Foster
2015-01-20 16:44 ` Jan Kara [this message]
2015-01-20 22:14 ` Dave Chinner
2015-01-20 22:35 ` Jan Kara
2015-01-20 23:14 ` Dave Chinner
2015-01-15 10:18 ` [PATCH 2/3] xfs: Remove some useless flags tests Jan Kara
2015-01-15 13:28 ` Brian Foster
2015-01-15 10:18 ` [PATCH 3/3] xfs: Remove some pointless quota checks Jan Kara
2015-01-15 13:28 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120164400.GB3648@quack.suse.cz \
--to=jack@suse.cz \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox