Re: [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF}

Jan Kara
2015-01-20T17:01:46Z

On Mon 19-01-15 01:01:21, Christoph Hellwig wrote:
> On Fri, Jan 16, 2015 at 01:47:36PM +0100, Jan Kara wrote:
> > Make Q_QUOTAON / Q_QUOTAOFF quotactl call ->quota_enable /
> > ->quota_disable callback when provided. To match current behavior of
> > ocfs2 & ext4 we make these quotactls turn on / off quota enforcement for
> > appropriate quota type.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> > fs/quota/quota.c | 31 +++++++++++++++++++++++++++----
> > include/linux/quotaops.h | 2 ++
> > 2 files changed, 29 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/quota/quota.c b/fs/quota/quota.c
> > index 5b307e2b5719..748716ffee48 100644
> > --- a/fs/quota/quota.c
> > +++ b/fs/quota/quota.c
> > @@ -66,18 +66,43 @@ static int quota_sync_all(int type)
> > return ret;
> > }
> >
> > +unsigned int qtype_limit_flag(int type)
> > +{
> > + switch (type) {
> > + case USRQUOTA:
> > + return FS_QUOTA_UDQ_ENFD;
> > + case GRPQUOTA:
> > + return FS_QUOTA_GDQ_ENFD;
> > + case PRJQUOTA:
> > + return FS_QUOTA_PDQ_ENFD;
> > + }
> > + return 0;
>
>
> What's the limit_ in the name supposed to mean?
qtype_enforce_flag() explains probably better what's going on so I've
used that instead.

Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR