Re: [PATCH 12/17] xfs: Convert to using ->get_state callback

Jan Kara
2015-01-20T17:33:11Z

On Mon 19-01-15 01:38:10, Christoph Hellwig wrote:
> > +static void xfs_qm_fill_state(struct qc_type_state *tstate,
>
> Normal xfs style would be to keep the "static void " on a separate line,
> as well as the arguments, e.g.
OK, will change it to conform to the XFS coding style.

> static void
> xfs_qm_fill_state(
> struct qc_type_state *tstate,
>
> >
> > + struct xfs_mount *mp,
> > + struct xfs_inode *ip,
> > + xfs_ino_t ino)
>
> No need to pass mp, as it can be derived as ip->i_mount.
Good point.

> Btw, I think this code should move into xfs_quotaops.c now
> that it ties into the Linux quota interface, and xfs_qm_scall_getstate
> should be folded into xfs_fs_get_quota_state.
OK, will do.

Honza

--
Jan Kara <jack@suse.cz>
SUSE Labs, CR