public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: Wang Sheng-Hui <shhuiw@foxmail.com>, xfs <xfs@oss.sgi.com>
Subject: Re: question about one example in section 3.2.3 of "XFS Filesystem Structure"
Date: Fri, 30 Jan 2015 09:32:50 +1100	[thread overview]
Message-ID: <20150129223249.GB6282@dastard> (raw)
In-Reply-To: <20150129132023.GA44129@bfoster.bfoster>

On Thu, Jan 29, 2015 at 08:20:24AM -0500, Brian Foster wrote:
> On Thu, Jan 29, 2015 at 06:39:51PM +0800, Wang Sheng-Hui wrote:
> > Dear,
> > 
> > I'm reading "XFS Filesystem Structure" from the link 
> >              http://xfs.org/docs/xfsdocs-xml-dev/XFS_Filesystem_Structure//tmp/en-US/html/index.html
> > and confused by one example in section 3.2.3:
> >              http://xfs.org/docs/xfsdocs-xml-dev/XFS_Filesystem_Structure//tmp/en-US/html/AG_Free_List.html
> > ---------------------------------------------------------------------------
> > xfs_db> fsblock 7
> > xfs_db> type bnobt
> > xfs_db> p
> > magic = 0x41425442
> > level = 1
> > numrecs = 4
> > leftsib = null
> > rightsib = null
> > keys[1-4] = [startblock,blockcount]
> >            1:[12,16] 2:[184586,3] 3:[225579,1] 4:[511629,1]
> > ptrs[1-4] = 1:2 2:83347 3:6 4:4
> > 
> > Blocks 2, 83347, 6 and 4 contain the leaves for the free space B+tree by starting block. Block 2 would contain offsets 16 up to but not including 184586 while block 4 would have all offsets from 511629 to the end of the AG. 
> > ---------------------------------------------------------------------------
> > 
> > I have thought block 2 contains offsets start from 12, and it will cover 16 free blocks.
> > I wonder why block 2 contains offsets start at 16, instead of 12 here?
> > 
> 
> The text above looks like a typo to me. I believe the
> [startblock,blockcount] shown in each higher level block of the btree
> (e.g., level > 0) represents the first record available in the
> associated block pointed at by 'ptr' (the next level down).
> 
> The above should say that block 2 contains offsets "12 up to but not
> including 184586 ..." and so on. I'm not really sure what the process is
> with these docs and where the source lies vs. what content is generated.
> I thought Dave had done something a while back with intent to try and
> organize docs but the details escape me... perhaps he can chime in on
> if/how this can be edited, if you're willing to post a fix. ;)

I have an ascii-doc converted version of this document that I want
to become the master source for this published document in this
git tree:

git://oss.sgi.com/xfs/xfs-documentation.git

Patches to fix the documentation, or converting any of the other XFS
documentation to asciidoc format (including man pages, xml, stuff,
the faq page on the Wiki, etc) should be made against this
repository and sent to the list.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2015-01-29 22:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 10:39 question about one example in section 3.2.3 of "XFS Filesystem Structure" Wang Sheng-Hui
2015-01-29 13:20 ` Brian Foster
2015-01-29 22:32   ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150129223249.GB6282@dastard \
    --to=david@fromorbit.com \
    --cc=bfoster@redhat.com \
    --cc=shhuiw@foxmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox