From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 3E6438000 for ; Tue, 3 Feb 2015 17:36:18 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 1AC668F8073 for ; Tue, 3 Feb 2015 15:36:18 -0800 (PST) Received: from ipmail05.adl6.internode.on.net (ipmail05.adl6.internode.on.net [150.101.137.143]) by cuda.sgi.com with ESMTP id KxnFWKaDXEP8JwSB for ; Tue, 03 Feb 2015 15:36:15 -0800 (PST) Date: Wed, 4 Feb 2015 10:34:50 +1100 From: Dave Chinner Subject: Re: [PATCH 1/5] xfs: struct xfs_sb is no longer tied to the on-disk format Message-ID: <20150203233450.GM4251@dastard> References: <1422826983-29570-1-git-send-email-david@fromorbit.com> <1422826983-29570-2-git-send-email-david@fromorbit.com> <20150202084102.GA28121@infradead.org> <20150202193020.GJ6282@dastard> <20150203213744.GA31631@infradead.org> <20150203214608.GJ4251@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150203214608.GJ4251@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Wed, Feb 04, 2015 at 08:46:09AM +1100, Dave Chinner wrote: > On Tue, Feb 03, 2015 at 01:37:44PM -0800, Christoph Hellwig wrote: > > On Tue, Feb 03, 2015 at 06:30:21AM +1100, Dave Chinner wrote: > > > > I'd expect to move it close to stuct xfs_mount, and maybe even merge > > > > it into that in the long run. > > > > > > I guess moving the structure there is fine, but we still want all > > > the version functions to be shared with userspace, which then makes > > > for an interesting set of dependencies. Any other ideas? > > > > Are they really worth the sharing? If they are worth it we'll > > need somethign that can expect a xfs_sb/xfs_mount to be defined. > > I suppose we could stop sharing them - they change rarely enough > and it's only a few lines of code for each new feature that would > then need to be duplicated. Not a huge burden... Just a further thought on this - I might keep the per-cpu counters in the struct mount. That way the to/from disk code only needs to sum/set the per-cpu counter values to/from the m_sb as they currently do and so the xfs_sb can remain unchanged for the moment. That might be a cleaner way to start this patchset, especially as we already have the per-cpu counter hooks in all the places we need them. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs