Re: [PATCH 6/7] xfs: replace xfs_mod_incore_sb_batched

Brian Foster
2015-02-05T14:27:34Z

On Thu, Feb 05, 2015 at 06:19:54AM -0800, Christoph Hellwig wrote:
> On Thu, Feb 05, 2015 at 09:10:44AM -0500, Brian Foster wrote:
> > > /* apply remaining deltas */
> > > + spin_lock(&mp->m_sb_lock);
> > > if (rtxdelta) {
> > > - error = xfs_mod_frextents(mp, rtxdelta);
> > > + error = xfs_sb_mod64(&mp->m_sb.sb_frextents, rtxdelta);
> >
> > Any reason why we don't continue to use the xfs_mod_frextents() function
> > introduced in the previous patch? Seems like we should be consistent one
> > way or the other.
>
> We're already under the sb_lock and would need another lock roundtrip to
> avoid a deadlock in that case. But mit might be worth to simply make
> the real time extent counter a percpu one to behave similar to the other
> counters that can be manipulated outside of the transaction commit code.
>

Ah, thanks... missed that the lock was taken there. This one looks fine
to me as well:

Reviewed-by: Brian Foster <bfoster@redhat.com>

> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs