From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/7] xfs: replace xfs_mod_incore_sb_batched
Date: Thu, 5 Feb 2015 06:19:54 -0800 [thread overview]
Message-ID: <20150205141954.GA18047@infradead.org> (raw)
In-Reply-To: <20150205141044.GH31625@laptop.bfoster>
On Thu, Feb 05, 2015 at 09:10:44AM -0500, Brian Foster wrote:
> > /* apply remaining deltas */
> > + spin_lock(&mp->m_sb_lock);
> > if (rtxdelta) {
> > - error = xfs_mod_frextents(mp, rtxdelta);
> > + error = xfs_sb_mod64(&mp->m_sb.sb_frextents, rtxdelta);
>
> Any reason why we don't continue to use the xfs_mod_frextents() function
> introduced in the previous patch? Seems like we should be consistent one
> way or the other.
We're already under the sb_lock and would need another lock roundtrip to
avoid a deadlock in that case. But mit might be worth to simply make
the real time extent counter a percpu one to behave similar to the other
counters that can be manipulated outside of the transaction commit code.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-02-05 14:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 20:54 [PATCH 0/7 V2] xfs: use generic percpu counters for icsb Dave Chinner
2015-02-04 20:54 ` [PATCH 1/7] xfs: use generic percpu counters for inode counter Dave Chinner
2015-02-05 14:09 ` Brian Foster
2015-02-23 20:55 ` Christoph Hellwig
2015-02-04 20:54 ` [PATCH 2/7] xfs: use generic percpu counters for free " Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-23 20:56 ` Christoph Hellwig
2015-02-04 20:54 ` [PATCH 3/7] xfs: use generic percpu counters for free block counter Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-05 14:18 ` Brian Foster
2015-02-23 20:57 ` Christoph Hellwig
2015-02-04 20:54 ` [PATCH 4/7] xfs: Remove icsb infrastructure Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-23 20:59 ` Christoph Hellwig
2015-02-04 20:54 ` [PATCH 5/7] xfs: introduce xfs_mod_frextents Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-23 21:02 ` Christoph Hellwig
2015-02-04 20:54 ` [PATCH 6/7] xfs: replace xfs_mod_incore_sb_batched Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-05 14:19 ` Christoph Hellwig [this message]
2015-02-05 14:27 ` Brian Foster
2015-02-04 20:54 ` [PATCH 7/7] xfs: remove xfs_mod_incore_sb API Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-05 14:08 ` [PATCH 0/7 V2] xfs: use generic percpu counters for icsb Brian Foster
2015-02-05 22:18 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205141954.GA18047@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox