From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 5436C803D for ; Thu, 5 Feb 2015 08:19:57 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 417488F8066 for ; Thu, 5 Feb 2015 06:19:57 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id NwDNKG7tA8CBSPxX (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Thu, 05 Feb 2015 06:19:56 -0800 (PST) Date: Thu, 5 Feb 2015 06:19:54 -0800 From: Christoph Hellwig Subject: Re: [PATCH 6/7] xfs: replace xfs_mod_incore_sb_batched Message-ID: <20150205141954.GA18047@infradead.org> References: <1423083249-27493-1-git-send-email-david@fromorbit.com> <1423083249-27493-7-git-send-email-david@fromorbit.com> <20150205141044.GH31625@laptop.bfoster> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150205141044.GH31625@laptop.bfoster> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Brian Foster Cc: xfs@oss.sgi.com On Thu, Feb 05, 2015 at 09:10:44AM -0500, Brian Foster wrote: > > /* apply remaining deltas */ > > + spin_lock(&mp->m_sb_lock); > > if (rtxdelta) { > > - error = xfs_mod_frextents(mp, rtxdelta); > > + error = xfs_sb_mod64(&mp->m_sb.sb_frextents, rtxdelta); > > Any reason why we don't continue to use the xfs_mod_frextents() function > introduced in the previous patch? Seems like we should be consistent one > way or the other. We're already under the sb_lock and would need another lock roundtrip to avoid a deadlock in that case. But mit might be worth to simply make the real time extent counter a percpu one to behave similar to the other counters that can be manipulated outside of the transaction commit code. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs