From: Dave Chinner <david@fromorbit.com>
To: Wang Sheng-Hui <shhuiw@foxmail.com>
Cc: bfoster@redhat.com, tinguely@sgi.com, sandeen@sandeen.net,
hch@lst.de, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: move the comment on log device near the right log dev check in xfs_mount_validate_sb
Date: Mon, 9 Feb 2015 08:20:51 +1100 [thread overview]
Message-ID: <20150208212051.GZ4251@dastard> (raw)
In-Reply-To: <1423370704-3464-1-git-send-email-shhuiw@foxmail.com>
On Sun, Feb 08, 2015 at 12:45:04PM +0800, Wang Sheng-Hui wrote:
> The beginning is about magic and version number check.
> Move the comment on log device near the log dev check logic.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
The comment is old and redundant. The error messages document the
reason for the checks better than the comment and the comments about
volume mounts date back to Irix and so aren't relevant any more. So
just remove the comment.
> ---
> fs/xfs/libxfs/xfs_sb.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
> index 752915f..b4bb852 100644
> --- a/fs/xfs/libxfs/xfs_sb.c
> +++ b/fs/xfs/libxfs/xfs_sb.c
> @@ -174,20 +174,13 @@ xfs_mount_validate_sb(
> bool check_inprogress,
> bool check_version)
> {
> + /* check magic number and version number */
No need to add a redundant comment - it is obvious what the code it
refers to is checking.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-02-08 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-08 4:45 [PATCH] xfs: move the comment on log device near the right log dev check in xfs_mount_validate_sb Wang Sheng-Hui
2015-02-08 21:20 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150208212051.GZ4251@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=hch@lst.de \
--cc=sandeen@sandeen.net \
--cc=shhuiw@foxmail.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox