From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 0/2] xfs: pass mp to XFS_WANT_CORRUPTED_*
Date: Mon, 9 Feb 2015 08:35:02 +1100 [thread overview]
Message-ID: <20150208213502.GA4251@dastard> (raw)
In-Reply-To: <54D53E8C.8070207@redhat.com>
On Fri, Feb 06, 2015 at 04:22:04PM -0600, Eric Sandeen wrote:
> These 2 patches provide information about which filesystem
> hit the error...
If we are going to touch every one of these macros, then can we
rename them to something a little shorter like XFS_CORRUPT_GOTO()
and XFS_CORRUPT_RETURN() at the same time? That will make the code a
little less eye-bleedy where there are lots of these statements,
and make formatting of complex checks a bit easier, too...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-02-08 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 22:22 [PATCH 0/2] xfs: pass mp to XFS_WANT_CORRUPTED_* Eric Sandeen
2015-02-06 22:22 ` [PATCH 1/2] xfs: pass mp to XFS_WANT_CORRUPTED_GOTO Eric Sandeen
2015-02-06 22:23 ` [PATCH 2/2] xfs: pass mp to XFS_WANT_CORRUPTED_RETURN Eric Sandeen
2015-02-08 21:35 ` Dave Chinner [this message]
2015-02-09 13:09 ` [PATCH 0/2] xfs: pass mp to XFS_WANT_CORRUPTED_* Brian Foster
2015-02-09 16:42 ` Eric Sandeen
2015-02-09 21:17 ` Dave Chinner
2015-02-09 21:43 ` Brian Foster
2015-02-09 21:58 ` Dave Chinner
2015-02-10 0:00 ` Eric Sandeen
2015-02-10 10:06 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150208213502.GA4251@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox