From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: "Michael L. Semon" <mlsemon35@gmail.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: xfs_alloc_fix_minleft can underflow near ENOSPC
Date: Tue, 17 Feb 2015 10:17:16 +1100 [thread overview]
Message-ID: <20150216231716.GB4251@dastard> (raw)
In-Reply-To: <54E22A76.40106@sgi.com>
On Mon, Feb 16, 2015 at 11:35:50AM -0600, Mark Tinguely wrote:
> Thanks Michael, you don't need to hold your test box for me. I do
> have a way to recreate these ABBA AGF buffer allocation deadlocks
> and understand the whys and hows very well. I don't have a community
> way to make a xfstest for it but I think your test is getting close.
If you know what is causing them, then please explain how it occurs
and how you think it needs to be fixed. Just telling us that you know
something that we don't doesn't help us solve the problem. :(
In general, the use of the args->firstblock is supposed to avoid the
ABBA locking order issues with multiple allocations in the one
transaction by preventing AG selection loops from looping back into
AGs with a lower index than the first allocation that was made.
So if you are seeing deadlocks, then it may be that we aren't
following this constraint correctly in all locations....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-02-16 23:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 23:14 [PATCH] xfs: xfs_alloc_fix_minleft can underflow near ENOSPC Dave Chinner
2015-02-13 23:40 ` Mark Tinguely
2015-02-14 23:29 ` Dave Chinner
2015-02-16 3:39 ` Michael L. Semon
2015-02-16 17:35 ` Mark Tinguely
2015-02-16 23:17 ` Dave Chinner [this message]
2015-02-17 15:36 ` Michael L. Semon
2015-02-18 0:48 ` Dave Chinner
2015-02-18 15:32 ` Michael L. Semon
2015-02-16 13:41 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216231716.GB4251@dastard \
--to=david@fromorbit.com \
--cc=mlsemon35@gmail.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox