From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: Pratyush Anand <panand@redhat.com>,
jbastian@redhat.com, ddutile@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH RFC] fs: xfs: Fix xfs_trans_read_buf event tracing
Date: Fri, 20 Feb 2015 08:37:46 +1100 [thread overview]
Message-ID: <20150219213746.GV12722@dastard> (raw)
In-Reply-To: <20150219172028.GC2291@laptop.bfoster>
On Thu, Feb 19, 2015 at 12:20:28PM -0500, Brian Foster wrote:
> On Thu, Feb 19, 2015 at 06:54:33PM +0530, Pratyush Anand wrote:
> > My root file system is xfs. As soon as I enable event for
> > xfs_trans_read_buf `echo xfs:xfs_trans_read_buf >>
> > /sys/kernel/debug/tracing/set_event`, I see a kernel panic.
> >
> > A little bit of debugging shows that bp->b_fspriv is NULL many a time
> > when trace_xfs_trans_read_buf(bp->b_fspriv) is called.
> >
> > I do not have any idea about xfs filesystem. So, I am not sure, if it
> > is expected to have bp->b_fspriv = NULL at this location.
> >
> > This patch fixes the issue, until we have a better fix.
> >
> > Signed-off-by: Pratyush Anand <panand@redhat.com>
> > ---
>
> A fix for this has been posted here:
>
> http://oss.sgi.com/archives/xfs/2015-02/msg00101.html
It's already in the 3.20-rc0 kernel, and it was marked as a stable
patch so should be fixed in the next 3.19 stable kernel.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-02-19 21:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 13:24 [PATCH RFC] fs: xfs: Fix xfs_trans_read_buf event tracing Pratyush Anand
2015-02-19 16:39 ` Eric Sandeen
2015-02-19 22:32 ` Don Dutile
2015-02-19 17:20 ` Brian Foster
2015-02-19 17:25 ` Pratyush Anand
2015-02-19 21:37 ` Dave Chinner [this message]
2015-02-19 22:35 ` Don Dutile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219213746.GV12722@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=ddutile@redhat.com \
--cc=jbastian@redhat.com \
--cc=panand@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox