From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: ensure truncate forces zeroed blocks to disk
Date: Tue, 24 Feb 2015 10:10:15 +1100 [thread overview]
Message-ID: <20150223231015.GX4251@dastard> (raw)
In-Reply-To: <20150223205109.GE13522@infradead.org>
On Mon, Feb 23, 2015 at 12:51:09PM -0800, Christoph Hellwig wrote:
> This looks correct, but is there a good (performance) reason against
> simply unconditionally flushing and waiting?
No idea. All I am concerned about is correctness - getting the
partial block flushed in the case that the on-disk size is the same
as the in-memory size is the fix needed here, otherwise the
behaviour should be unchanged.
Given that I'm not sure what the effect of an unconditional flush is
going to be, I'm not going to mix such a change with an otherwise
obvious data corruption fix that we need to backport to other
kernels. If you have the time to determine there is no performance
impact from an unconditional flush, then I'll happily take the
change. ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-02-23 23:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 22:48 [PATCH] xfs: ensure truncate forces zeroed blocks to disk Dave Chinner
2015-02-19 14:28 ` Brian Foster
2015-02-23 20:51 ` Christoph Hellwig
2015-02-23 23:10 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223231015.GX4251@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox