From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: superblock buffers need to be sector sized
Date: Wed, 25 Feb 2015 17:40:38 +1100 [thread overview]
Message-ID: <20150225064038.GE18360@dastard> (raw)
In-Reply-To: <20150224133652.GB45528@bfoster.bfoster>
On Tue, Feb 24, 2015 at 08:36:52AM -0500, Brian Foster wrote:
> On Tue, Feb 24, 2015 at 06:12:24PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > In secondary_sb_wack() we zero the unused portion of both the
> > on-disk superblock and the in-memory copy that we have. When
> > the device sector size is 4k, this causes xfs_repair to crash like
> > so:
> >
> > # xfs_repair /dev/ram1
> > Phase 1 - find and verify superblock...
> > Phase 2 - using internal log
> > - zero log...
> > - scan filesystem freespace and inode maps...
> > bad magic number
> > bad on-disk superblock 3 - bad magic number
> > primary/secondary superblock 3 conflict - AG superblock geometry info conflicts with filesystem geometry
> > zeroing unused portion of secondary superblock (AG #3)
> > #
> >
> > The stack trace is indicative:
> >
> > #0 memset ()
> > #1 0x000000000040404b in secondary_sb_wack
> > #2 verify_set_agheader
> > #3 0x0000000000427b4b in scan_ag
> > #4 0x000000000042a2ca in worker_thread
> > #5 0x00007ffff77ba0a4 in start_thread
> > #6 0x00007ffff74efc2d in clone
> >
> > Which points at memset overrunning the in memory buffer, as it is
> > only 512 bytes in length.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > ---
>
> The patch subject line should probably say 'xfsprogs:' or 'repair:,'
> otherwise this looks good to me:
Right, my mistake.
> Reviewed-by: Brian Foster <bfoster@redhat.com>
Thanks,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-02-25 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 7:12 [PATCH] xfs: superblock buffers need to be sector sized Dave Chinner
2015-02-24 13:36 ` Brian Foster
2015-02-25 6:40 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225064038.GE18360@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox