From: Brian Foster <bfoster@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Fix quota type in quota structures when reusing quota file
Date: Wed, 25 Feb 2015 07:45:25 -0500 [thread overview]
Message-ID: <20150225124525.GA28053@bfoster.bfoster> (raw)
In-Reply-To: <20150225104057.GA22736@quack.suse.cz>
On Wed, Feb 25, 2015 at 11:40:57AM +0100, Jan Kara wrote:
> Ping? Can you guys please review / pick-up the fix? Thanks!
>
Looks like this is in Dave's tree:
commit dfcc70a8c868fe03276fa59864149708fb41930b
Author: Jan Kara <jack@suse.cz>
Date: Mon Feb 23 22:34:17 2015 +1100
xfs: Fix quota type in quota structures when reusing quota file
...
Brian
> Honza
>
> On Tue 17-02-15 16:57:10, Jan Kara wrote:
> > For filesystems without separate project quota inode field in the
> > superblock we just reuse project quota file for group quotas (and vice
> > versa) if project quota file is allocated and we need group quota file.
> > When we reuse the file, quota structures on disk suddenly have wrong
> > type stored in d_flags though. Nobody really cares about this (although
> > structure type reported to userspace was wrong as well) except
> > that after commit 14bf61ffe6ac (quota: Switch ->get_dqblk() and
> > ->set_dqblk() to use bytes as space units) assertion in
> > xfs_qm_scall_getquota() started to trigger on xfs/106 test (apparently I
> > was testing without XFS_DEBUG so I didn't notice when submitting the
> > above commit).
> >
> > Fix the problem by properly resetting ddq->d_flags when running quotacheck
> > for a quota file.
> >
> > CC: stable@vger.kernel.org
> > Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> > fs/xfs/xfs_qm.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> > index 3e8186279541..dd0dcc7b76cd 100644
> > --- a/fs/xfs/xfs_qm.c
> > +++ b/fs/xfs/xfs_qm.c
> > @@ -836,6 +836,11 @@ xfs_qm_reset_dqcounts(
> > */
> > xfs_dqcheck(mp, ddq, id+j, type, XFS_QMOPT_DQREPAIR,
> > "xfs_quotacheck");
> > + /*
> > + * Reset type in case we are reusing group quota file for
> > + * project quotas or vice versa
> > + */
> > + ddq->d_flags = type;
> > ddq->d_bcount = 0;
> > ddq->d_icount = 0;
> > ddq->d_rtbcount = 0;
> > --
> > 2.1.4
> >
> --
> Jan Kara <jack@suse.cz>
> SUSE Labs, CR
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-02-25 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 15:57 [PATCH] xfs: Fix quota type in quota structures when reusing quota file Jan Kara
2015-02-25 10:40 ` Jan Kara
2015-02-25 12:45 ` Brian Foster [this message]
2015-02-25 14:17 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225124525.GA28053@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=jack@suse.cz \
--cc=viro@ZenIV.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox