Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

Ingo Molnar
2015-03-08T10:02:35Z

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Sat, Mar 7, 2015 at 8:36 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > And the patch Dave bisected to is a relatively simple patch. Why
> > not simply revert it to see whether that cures much of the
> > problem?
>
> So the problem with that is that "pmd_set_numa()" and friends simply
> no longer exist. So we can't just revert that one patch, it's the
> whole series, and the whole point of the series.

Yeah.

> What confuses me is that the only real change that I can see in that
> patch is the change to "change_huge_pmd()". Everything else is
> pretty much a 100% equivalent transformation, afaik. Of course, I
> may be wrong about that, and missing something silly.

Well, there's a difference in what we write to the pte:

#define _PAGE_BIT_NUMA (_PAGE_BIT_GLOBAL+1)
#define _PAGE_BIT_PROTNONE _PAGE_BIT_GLOBAL

and our expectation was that the two should be equivalent methods from
the POV of the NUMA balancing code, right?

> And the changes to "change_huge_pmd()" were basically re-done
> differently by subsequent patches anyway.
>
> The *only* change I see remaining is that change_huge_pmd() now does
>
> entry = pmdp_get_and_clear_notify(mm, addr, pmd);
> entry = pmd_modify(entry, newprot);
> set_pmd_at(mm, addr, pmd, entry);
>
> for all changes. It used to do that "pmdp_set_numa()" for the
> prot_numa case, which did just
>
> pmd_t pmd = *pmdp;
> pmd = pmd_mknuma(pmd);
> set_pmd_at(mm, addr, pmdp, pmd);
>
> instead.
>
> I don't like the old pmdp_set_numa() because it can drop dirty bits,
> so I think the old code was actively buggy.

Could we, as a silly testing hack not to be applied, write a
hack-patch that re-introduces the racy way of setting the NUMA bit, to
confirm that it is indeed this difference that changes pte visibility
across CPUs enough to create so many more faults?

Because if the answer is 'yes', then we can safely say: 'we regressed
performance because correctness [not dropping dirty bits] comes before
performance'.

If the answer is 'no', then we still have a mystery (and a regression)
to track down.

As a second hack (not to be applied), could we change:

#define _PAGE_BIT_PROTNONE _PAGE_BIT_GLOBAL

to:

#define _PAGE_BIT_PROTNONE (_PAGE_BIT_GLOBAL+1)

to double check that the position of the bit does not matter?

I don't think we've exhaused all avenues of analysis here.

Thanks,

Ingo