Re: [PATCH 1/4] xfs_repair: validate & fix inode CRCs

Eric Sandeen
2015-03-13T22:42:49Z

On 3/13/15 8:20 AM, Brian Foster wrote:

...

> What about verify_mode? It should probably report the inode as bunk if
> the crc is bad. Some of the subsequent checks handle this with some
> logic to just return 1 if something is bogus and we're in verify mode.

So, I read through the verify_mode portion on the plane ride back; I think
it's gotten a bit inconsistent over time. I feel like I understand it a
bit better now, and will send a v3 which matches what I understand to be
its intent, and another patch to document it & make the rest consistent.

Thanks for keeping me honest. ;)

-Eric