From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 2DE157F3F for ; Fri, 13 Mar 2015 09:34:25 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id 1CBAF304051 for ; Fri, 13 Mar 2015 07:34:21 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 5g8vy2CBQw7EShaK (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 13 Mar 2015 07:34:21 -0700 (PDT) Date: Fri, 13 Mar 2015 10:34:17 -0400 From: Brian Foster Subject: Re: [PATCH 1/4] xfs_repair: dirty inode in process_sf_dir2 if we change namelen Message-ID: <20150313143417.GD2678@laptop.bfoster> References: <54FF59DA.60700@sandeen.net> <54FF5A5F.90201@sandeen.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <54FF5A5F.90201@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs-oss On Tue, Mar 10, 2015 at 04:55:59PM -0400, Eric Sandeen wrote: > There are two "fix sfep->namelen" cases, but we only mark > *dino_dirty = 1 in one of them. Add the other to ensure that > the change gets written out. > > Signed-off-by: Eric Sandeen > --- Reviewed-by: Brian Foster > > diff --git a/repair/dir2.c b/repair/dir2.c > index 6b8964d..25793e9 100644 > --- a/repair/dir2.c > +++ b/repair/dir2.c > @@ -881,6 +881,7 @@ _("entry \"%*.*s\" in shortform directory %" PRIu64 " references %s inode %" PRI > _("zero length entry in shortform dir %" PRIu64 ", resetting to %d\n"), > ino, namelen); > sfep->namelen = namelen; > + *dino_dirty = 1; > } else { > do_warn( > _("zero length entry in shortform dir %" PRIu64 ", would set to %d\n"), > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs