From: Dave Chinner <david@fromorbit.com>
To: Sanidhya Kashyap <sanidhya.gatech@gmail.com>
Cc: taesoo@gatech.edu, "Kashyap, Sanidhya" <sanidhya@gatech.edu>,
xfs@oss.sgi.com, csong@gatech.edu, blee@gatech.edu,
changwoo@gatech.edu
Subject: Re: Question about GFP_KERNEL argument in radix_tree_preload
Date: Mon, 23 Mar 2015 15:28:47 +1100 [thread overview]
Message-ID: <20150323042847.GN28621@dastard> (raw)
In-Reply-To: <CADa969g-jGyYc1ts+JamuD0Ze-Mcp+X8am7rAfDeY0wXC4A6gg@mail.gmail.com>
On Sun, Mar 22, 2015 at 11:49:34PM -0400, Sanidhya Kashyap wrote:
> Hello David,
>
> We have been doing some analysis on file systems and have a question
> regarding the GFP_KERNEL flag used in radix_tree_preload in
> xfs_mru_cache_insert.
>
> We think that this should be GFP_NOFS as it is related to the block
> allocation and other file systems(eg btrfs,ext2) are also using
> GFP_NOFS for the same.
>
> It would be great if you can let us know your reason for using that
> flag and which one is the correct option?
<shrug>
That code was written by someone else and it was 7-8 years ago I
cleaned it up for Linux. Whatever reason there was is long since
lost.
If it's wrong (e.g. can be called inside a transaction), send a
patch to fix it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-03-23 4:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 3:49 Question about GFP_KERNEL argument in radix_tree_preload Sanidhya Kashyap
2015-03-23 4:28 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323042847.GN28621@dastard \
--to=david@fromorbit.com \
--cc=blee@gatech.edu \
--cc=changwoo@gatech.edu \
--cc=csong@gatech.edu \
--cc=sanidhya.gatech@gmail.com \
--cc=sanidhya@gatech.edu \
--cc=taesoo@gatech.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox