* Question about GFP_KERNEL argument in radix_tree_preload
@ 2015-03-23 3:49 Sanidhya Kashyap
2015-03-23 4:28 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Sanidhya Kashyap @ 2015-03-23 3:49 UTC (permalink / raw)
To: david; +Cc: taesoo, Kashyap, Sanidhya, xfs, csong, blee, changwoo
Hello David,
We have been doing some analysis on file systems and have a question
regarding the GFP_KERNEL flag used in radix_tree_preload in
xfs_mru_cache_insert.
We think that this should be GFP_NOFS as it is related to the block
allocation and other file systems(eg btrfs,ext2) are also using
GFP_NOFS for the same.
It would be great if you can let us know your reason for using that
flag and which one is the correct option?
Thanks,
Sanidhya
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Question about GFP_KERNEL argument in radix_tree_preload
2015-03-23 3:49 Question about GFP_KERNEL argument in radix_tree_preload Sanidhya Kashyap
@ 2015-03-23 4:28 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2015-03-23 4:28 UTC (permalink / raw)
To: Sanidhya Kashyap; +Cc: taesoo, Kashyap, Sanidhya, xfs, csong, blee, changwoo
On Sun, Mar 22, 2015 at 11:49:34PM -0400, Sanidhya Kashyap wrote:
> Hello David,
>
> We have been doing some analysis on file systems and have a question
> regarding the GFP_KERNEL flag used in radix_tree_preload in
> xfs_mru_cache_insert.
>
> We think that this should be GFP_NOFS as it is related to the block
> allocation and other file systems(eg btrfs,ext2) are also using
> GFP_NOFS for the same.
>
> It would be great if you can let us know your reason for using that
> flag and which one is the correct option?
<shrug>
That code was written by someone else and it was 7-8 years ago I
cleaned it up for Linux. Whatever reason there was is long since
lost.
If it's wrong (e.g. can be called inside a transaction), send a
patch to fix it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-23 4:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-23 3:49 Question about GFP_KERNEL argument in radix_tree_preload Sanidhya Kashyap
2015-03-23 4:28 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox