From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH 0/2] xfs: avoid overflow of attr3 leaf block headers with 64k blocks
Date: Wed, 25 Mar 2015 12:56:36 -0400 [thread overview]
Message-ID: <20150325165636.GA3436@laptop.bfoster> (raw)
In-Reply-To: <1424811024-24839-1-git-send-email-bfoster@redhat.com>
On Tue, Feb 24, 2015 at 03:50:22PM -0500, Brian Foster wrote:
> Hi all,
>
> As it turns out, some of the leaf block codepaths other than xattr
> addition look like they wouldn't work properly with an unaligned
> firstused value as demonstrated in my previous patch:
>
> http://oss.sgi.com/archives/xfs/2015-02/msg00479.html
>
> Here's an alternate approach that handles the overflow in the header
> conversion functions. It passes the basic tests so far, but more testing
> is needed to make sure I've made valid assumptions. Thoughts?
>
> FWIW, another approach could be to leak the last few bytes of the blocks
> (e.g., max firstused at the last valid aligned offset and update freemap
> size accordingly)...
>
ping?
> Brian
>
> Brian Foster (2):
> xfs: pass attr geometry to attr leaf header conversion functions
> xfs: use larger in-core attr firstused field and detect overflow
>
> fs/xfs/libxfs/xfs_attr_leaf.c | 99 +++++++++++++++++++++++++++++--------------
> fs/xfs/libxfs/xfs_attr_leaf.h | 6 ++-
> fs/xfs/libxfs/xfs_da_format.h | 8 +++-
> fs/xfs/xfs_attr_inactive.c | 3 +-
> fs/xfs/xfs_attr_list.c | 9 ++--
> 5 files changed, 86 insertions(+), 39 deletions(-)
>
> --
> 1.9.3
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-03-25 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 20:50 [PATCH 0/2] xfs: avoid overflow of attr3 leaf block headers with 64k blocks Brian Foster
2015-02-24 20:50 ` [PATCH 1/2] xfs: pass attr geometry to attr leaf header conversion functions Brian Foster
2015-03-25 20:51 ` Dave Chinner
2015-02-24 20:50 ` [PATCH 2/2] xfs: use larger in-core attr firstused field and detect overflow Brian Foster
2015-03-25 21:04 ` Dave Chinner
2015-03-25 16:56 ` Brian Foster [this message]
2015-03-25 17:59 ` [PATCH 0/2] xfs: avoid overflow of attr3 leaf block headers with 64k blocks Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325165636.GA3436@laptop.bfoster \
--to=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox