From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: pass attr geometry to attr leaf header conversion functions
Date: Thu, 26 Mar 2015 07:51:52 +1100 [thread overview]
Message-ID: <20150325205152.GZ28621@dastard> (raw)
In-Reply-To: <1424811024-24839-2-git-send-email-bfoster@redhat.com>
On Tue, Feb 24, 2015 at 03:50:23PM -0500, Brian Foster wrote:
> The firstused field of the xfs_attr3_leaf_hdr structure is subject to an
> overflow when fs blocksize is 64k. In preparation to handle this
> overflow in the header conversion functions, pass the attribute geometry
> to the functions that convert the in-core structure to and from the
> on-disk structure.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Hmmm. not sure I'm a great fan of this, but let's see.
Ok, this just a conversion patch, moving on to the second patch...
-Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-03-25 20:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 20:50 [PATCH 0/2] xfs: avoid overflow of attr3 leaf block headers with 64k blocks Brian Foster
2015-02-24 20:50 ` [PATCH 1/2] xfs: pass attr geometry to attr leaf header conversion functions Brian Foster
2015-03-25 20:51 ` Dave Chinner [this message]
2015-02-24 20:50 ` [PATCH 2/2] xfs: use larger in-core attr firstused field and detect overflow Brian Foster
2015-03-25 21:04 ` Dave Chinner
2015-03-25 16:56 ` [PATCH 0/2] xfs: avoid overflow of attr3 leaf block headers with 64k blocks Brian Foster
2015-03-25 17:59 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325205152.GZ28621@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox