From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: disallow ro->rw remount on norecovery mount
Date: Fri, 27 Mar 2015 07:59:58 +1100 [thread overview]
Message-ID: <20150326205958.GD28129@dastard> (raw)
In-Reply-To: <55146612.1070306@redhat.com>
On Thu, Mar 26, 2015 at 03:03:30PM -0500, Eric Sandeen wrote:
> There's a bit of a loophole in norecovery mount handling right
> now: an initial mount must be readonly, but nothing prevents
> a mount -o remount,rw from producing a writable, unrecovered
> xfs filesystem.
>
> It might be possible to try to perform a log recovery when this
> is requested, but I'm not sure it's worth the effort. For now,
> simply disallow this sort of transition.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Good catch.
Shouldn't this also check for a ro block device, and disallow the
rw remount if the block dev is ro?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-03-26 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 20:03 [PATCH] xfs: disallow ro->rw remount on norecovery mount Eric Sandeen
2015-03-26 20:59 ` Dave Chinner [this message]
2015-03-26 21:13 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326205958.GD28129@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox