From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC 1/2] xfs_db: enable blockget for v5 filesystems
Date: Tue, 7 Apr 2015 10:03:03 +1000 [thread overview]
Message-ID: <20150407000303.GB15810@dastard> (raw)
In-Reply-To: <20150318232356.GC24608@birch.djwong.org>
On Wed, Mar 18, 2015 at 04:23:56PM -0700, Darrick J. Wong wrote:
> Plumb in the necessary magic number checks and other fixups required
> to handle v5 filesystems. This requires Eric Sandeen's earlier patch
> rollup.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> db/check.c | 52 +++++++++++++++++++++++++++++++++++++++-------------
> 1 file changed, 39 insertions(+), 13 deletions(-)
>
> diff --git a/db/check.c b/db/check.c
> index 4fd9fd0..767022f 100644
> --- a/db/check.c
> +++ b/db/check.c
> @@ -799,8 +799,6 @@ blockget_f(
> * filters out, or we need to actually do the work to make check support
> * crc enabled filesystems.
> */
> - if (xfs_sb_version_hascrc(&mp->m_sb))
> - return 0;
This causes check to run from xfstests on v5 filesystems, which then
throws errors everywhere and fails every test. A more nuanced
enablement of blockget is required here....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-04-07 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 23:23 [RFC 1/2] xfs_db: enable blockget for v5 filesystems Darrick J. Wong
2015-04-07 0:03 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407000303.GB15810@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox